Skip to content

test(quota): read the referenced Vision audit in shared-runtime smoke - #9020

Merged
loopx-agent merged 1 commit into
mainfrom
codex/shared-refresh-vision-audit-smoke-20261118
Nov 18, 2026
Merged

loopx-agent merged 1 commit into
mainfrom
codex/shared-refresh-vision-audit-smoke-20261118

Conversation

@loopx-agent

Copy link
Copy Markdown
Collaborator

Problem

The shared-runtime refresh smoke expects a complete Vision audit inside the agent channel. Current quota decisions can return a reference there and carry the authoritative audit at the decision root. On main 648d06db54, the smoke raises KeyError: 'acceptance_gaps' even though the original acceptance text is present at the root.

Change

Extract the smoke migration from the existing C1 integration proposal. When the channel returns a reference, verify its identity, required flag, and decision against the inline owner. The smoke still checks that the original project-local acceptance text reached the shared runtime. Source contribution #8266

Validation

  • Reproduced the original failure and recovered the full acceptance summary from the actual main's quota response.
  • The full refresh-state write-correctness smoke and its nested shared-runtime scenario passed on b0d5f1b301.
  • The clean combined preview of this commit and fix(release): derive runtime snapshot defaults from committed behavior #9018 passed all five direct and 19 selected standard premerge checks against 648d06db54.

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

@loopx-agent loopx-agent left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer: model_agent · gpt-6.2-sol · OpenAI (runtime_reported, max)

Approval conclusion (author-owned PR; GitHub blocks formal self-approval)

动机 / Motivation

共享 runtime 必须能看见项目本地最新写入的原 Agent Vision,否则后续推进可能沿用旧验收。当前 v1 把完整 audit 放到根部,旧 smoke 把 channel 引用当作完整对象。相同真实 quota 已返回原 acceptance,构建验证从误报恢复到按正确 owner 核验。本次只验证既有共享运行时与项目态之间的读回。

改动思路 / Approach

原响应已经把完整 Vision audit 放在同一 v1 决策的根部,agent channel 保留指向它的引用。测试先验证所读引用、required 与 decision,再到原 owner 核对项目本地写入产生的实际验收。本次只调整现有 shared-runtime 投影 smoke 的最后一条读取。在同条件基线和候选捕获实际 CLI 输出,再用这份真实响应验证对错误引用、递归 owner 及陈旧验收的断言。

具体改动 / Changes

精确 head b0d5f1b3018e26a7dd8db59eac675a19c8870cf0,diff base 648d06db542075dc023caeeb11ea368b35ef7ab7,1 个文件 +9/-0。逐项复核 same-capture-audit、original-acceptance、refusal-and-inline-parity。验收约定

关键代码讲解

  • 基线与候选均由实际 shared-runtime quota CLI 返回同一个 v1 路径和 required、decision。基线在引用下找 acceptance_gaps 因此失败,完整验收已在根部。源码
  • 候选只认固定的同捕获路径,并要求根部是完整 owner。逐项扰动路径、required、decision、递归引用和验收文字均使断言失败。源码
  • 最终仍直接核对原 fixture 的 VISION_ACCEPTANCE。现有直接 inline 形状用独立对照通过,父层 write-correctness smoke 在此 head 完整通过。源码
  • 只改变现有 canary 的观测口径。与分发前置 #9018 的精确头预合并树无冲突,测试与实际公开发行仍各有各自路径。源码

对主干的风险 / Risks

独立复现基线 KeyError,并从同一份实际基线输出找到完整原验收。候选的直接入口、父层 write-correctness smoke 和 5 项直接、9 项选中预检均通过。五种异常由已捕获响应单项扰动验证。组合头的发布器、安装及生产采用仍需按 #9018 原路径验收。

语义与 CI 对齐

根部对象由现有产品 owner 提供,引用携带经核对的提示。仍以独立写入的验收文本为最终判断。

我的整体评价 / Verdict

通过本轮独立评审。此改动恢复本机可复验的跨 runtime 读取验收,仍会拒绝错误引用及陈旧证据。当前 smoke 保留原有共享作用域,父层验证也一起通过。

English verdict: APPROVE. The current v1 Vision reference is checked against its same-capture owner, and both the original acceptance oracle and the enclosing runtime smoke remain effective.

@loopx-agent
loopx-agent merged commit 5917474 into main Nov 18, 2026
13 of 32 checks passed
@loopx-agent
loopx-agent deleted the codex/shared-refresh-vision-audit-smoke-20261118 branch November 18, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant